Validate seed data #9989
Merged
Validate seed data #9989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
SeedValidation
branch
from
8743dbd
to
095fa74
Compare
ajcvickers
reviewed
Oct 6, 2017
| { | ||
| foreach (var entity in data) | ||
| { | ||
| if (entity.GetType() != typeof(TEntity)) |
There was a problem hiding this comment.
entity.GetType() != typeof(TEntity) [](start = 20, length = 35)
This has to be an exact match?
There was a problem hiding this comment.
yes, because any derived property will be ignored
ajcvickers
reviewed
Oct 6, 2017
| { | ||
| foreach (var stateManager in new[] { _sourceStateManager, _targetStateManager }) | ||
| { | ||
| if (stateManager == null) |
There was a problem hiding this comment.
if (stateManager == null) [](start = 15, length = 26)
When is one of the state manager's null?
There was a problem hiding this comment.
when there's no corresponding model
i.e. Starting from an empty DB or going to one
ajcvickers
reviewed
Oct 6, 2017
| /// directly from your code. This API may change or be removed in future releases. | ||
| /// </summary> | ||
| public delegate SharedTableEntryMap<TValue> SharedTableEntryMapFactory<TValue>(SharedTableEntryValueFactory<TValue> valueFactory); | ||
| } |
There was a problem hiding this comment.
Named delegates are...unusual...
There was a problem hiding this comment.
Funcs were too cumbersome
ajcvickers
approved these changes
Oct 6, 2017
Fix issues with discriminators and table splitting Part of #629
AndriySvyryd
force-pushed
the
SeedValidation
branch
from
095fa74
to
f711fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues with discriminators and table splitting
Part of #629