Use the DOTNET_ env var prefix #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test |
JunTaoLuo
approved these changes
Feb 7, 2019
| @@ -20,7 +20,7 @@ public static IHostBuilder CreateDefaultBuilder(string[] args) | |||
| builder.UseContentRoot(Directory.GetCurrentDirectory()); | |||
| builder.ConfigureHostConfiguration(config => | |||
| { | |||
| config.AddEnvironmentVariables(); // TODO: Prefix? | |||
| config.AddEnvironmentVariables("DOTNET_"); | |||
There was a problem hiding this comment.
nit: use a named variable for the prefix like we do everywhere else: https://github.com/aspnet/AspNetCore/blob/c458fe6ebe24ab94f098a453825e71207721b9b9/src/Hosting/Hosting/src/WebHostBuilder.cs#L44
|
@davidfowl reliably testing env vars needs out-of-proc functional testing. We don't have that infrastructure in Extensions and it isn't worth building for this. |
Merged
|
@Tratcher we need more than 0 coverage. I think it would be reasonable to write those tests in ASP.NET Core hosting since we do that the infrastructure on that side. |
|
Or part of the template I'm working on. |
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/aspnetcore#4150
@glennc