Fix for false-positive publish failures when tests fail #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
approved these changes
Apr 18, 2019
natemcmaster
pushed a commit
to dotnet-maestro-bot/Common
that referenced
this pull request
Apr 22, 2019
…Generic Host one (dotnet#1461)
natemcmaster
pushed a commit
to dotnet-maestro-bot/Common
that referenced
this pull request
Apr 22, 2019
…rom the Generic Host one (dotnet#1461)" (dotnet#1467) This reverts commit 8672b1b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PublishBuildArtifacts fails when artifacts/packages/ does not exist or is empty. This change will only publish packages if build.cmd succeeds (which means all tests, code signing, and compilation must pass)