Merge Microsoft.Extensions.WebEncoders from aspnet/HtmlAbstractions #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nit: add a couple of solution items
- #5 - provide `ToString()` implementation - add missing `null` checks in `WriteTo()`; remove extraneous one in the constructor - special-case `HtmlEncodedString` in `IHtmlContentBuilder.AppendFormat()` extension method nits: - ignore more files - add missing `null` checks in `HtmlContentBuilderExtensions` too
…r.AppendHtml(IHtmlContent) Fixes #4
See aspnet/Announcements#144 for more information.
See aspnet/Announcements#144 for more information.
- This package is pulled in transitively.
- currently attempts to `source KoreBuild.sh`
- aspnet/Universe#347 - `%KOREBUILD_VERSION%` doesn't work without this fix
- dotnet5.X => netstandard1.y (where y = x-1). - DNXCore50 => netstandardapp1.5. - Applied the same changes to ifdefs.
- dotnet/aspnetcore-internal#187 - remove `<RootNamespace>` settings but maintain other unique aspects e.g. `<DnxInvisibleContent ... />` - in a few cases, standardize on VS version `14.0` and not something more specific
Currently we overload the definition of WriteTo on IHtmlContent implementation classes to either represent a "real" write or a "flatten" by checking if the writer inherits HtmlText writer. This overloading is a bit of an odd fit and hides the real semantic we want for flattening. Additionally, we want to gradually make the concept of a pooled backing-buffer for IHtmlContent first-class - using pooled buffers dictates that we support move-semantics to some degree. This change makes the work that we do for flattening into pooled buffers explicit rather than hidden.
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
As a result of changing the way we apply servicing updates to aspnet core, this repo did not need the version bump because there are no planned product changes in this repo.
This reverts our previous policy of cascading versions on all servicing updates. This moves variables into the 'pinned' section, and points them to the latest stable release (versions that were used at the time of the 2.1.2 release).
Prior to reorganization, this source code was found in https://github.com/aspnet/HtmlAbstractions/tree/252ae0c434d93f5bfaf949c35edb9ef59730d0a3
Eilon
approved these changes
Nov 10, 2018
natemcmaster
force-pushed
the
namc/merge-we-2.1
branch
from
4e55012
to
ca683f3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of dotnet/aspnetcore#3598, this merges the source code for Microsoft.Extensions.WebEncoders into this repo.
This other project in aspnet/HtmlAbstractions will go to aspnet/AspNetCore, not year.
FYI @rynowak @mkArtakMSFT