Skip to content
This repository has been archived by the owner on Nov 6, 2018. It is now read-only.

[BREAKING CHANGE] public class Microsoft.Extensions.FileProviders.FileSystemInfoHelper was made static #243

Closed
javiercn opened this issue Nov 4, 2016 · 3 comments
Closed

[BREAKING CHANGE] public class Microsoft.Extensions.FileProviders.FileSystemInfoHelper was made static #243

javiercn opened this issue Nov 4, 2016 · 3 comments
Assignees
@natemcmaster
Labels
3 - Done bug
Milestone
1.1.0

Comments

@javiercn
Copy link
Member

javiercn commented Nov 4, 2016

V1:
public class FileSystemInfoHelper
V2:
public static class FileSystemInfoHelper

[ACTION for 1.1]: Undo the breaking change.
[ACTION for 2.0]: Make the class internal.
@javiercn
Copy link
Member Author

javiercn commented Nov 4, 2016

@Eilon @muratg

@javiercn javiercn added this to the 1.1.0 milestone Nov 4, 2016
@javiercn javiercn added the bug label Nov 4, 2016
@javiercn javiercn changed the title [BREAKING CHANGE] [BREAKING CHANGE] public class Microsoft.Extensions.FileProviders.FileSystemInfoHelper was made static Nov 4, 2016
@natemcmaster
Copy link
Contributor

Mea culpa. 0e21803

@natemcmaster natemcmaster self-assigned this Nov 4, 2016
@Eilon
Copy link
Member

Eilon commented Nov 4, 2016

No biggie, let's just make it un-static and we'll fix it in 2.0.

@Eilon Eilon added the 1 - Ready label Nov 4, 2016
@natemcmaster natemcmaster mentioned this issue Nov 4, 2016
Merged
@Eilon Eilon added 3 - Done and removed 1 - Ready labels Nov 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@natemcmaster natemcmaster

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@Eilon @natemcmaster @javiercn