Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Libraries Dependency Changes In 1.1 #1889

Closed
gensisns opened this issue Dec 23, 2016 · 4 comments
Closed

Extension Libraries Dependency Changes In 1.1 #1889

gensisns opened this issue Dec 23, 2016 · 4 comments

Comments

@gensisns
Copy link

We're using Configuration and DependencyInjection in a .NetFramework 4.6.1 project. All of the versions up to 1.0.1 worked just fine and didn't cause any problems. Version 1.1.0 has caused all lot of conflicts and problems in our project - after a lot of digging, we realized that the reason was the dependencies for all the extensions changed in 1.1 from depending on specific packages to depending on the NetStandard.Library.

Why was this change made for the extensions versus referencing the specific libraries the extensions need. The previous way allowed easy use in 4.6.1. Once the NetStandard.Library is included it pulls in System.Net.Http and lots and lots of other packages, which caused a lot of problems.

I'm wondering how this could be resolved / if the extensions could go back to referencing just the packages they need.

Thanks!

@Tratcher
Copy link
Member

It wasn't just Extensions that did this, The AspNetCore packages did this too. I'm only aware of one issue this has caused (aspnet/Security#1046, and yes it was with System.Net.Http). What other issues have you seen?

@muratg @pranavkm what was the reasoning for this change?

@gensisns
Copy link
Author

This was the first one we hit:
https://github.com/dotnet/corefx/issues/11100

For a project not using the full netstandard library or .netcore, it was so much easier to have a references to the couple packages that the extensions were using and not have 50+ packages installed for the full standard library.

@pranavkm
Copy link
Contributor

Past discussion on this topic - aspnet/HttpSysServer#268.

@aspnet-hello
Copy link

This issue is being closed because it has not been updated in 3 months.

We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.

natemcmaster pushed a commit that referenced this issue Nov 14, 2018
* Remove usage of TaskCache
ryanbrandenburg pushed a commit that referenced this issue Nov 27, 2018
-The client sample can now switch between TCP and HTTP connection layer by URI scheme
- Support net.tcp URI scheme for the TCP connection
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants