Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Upgrade to new DiagnosticSource package #391

Closed
rynowak opened this issue Oct 8, 2015 · 3 comments
Closed

Upgrade to new DiagnosticSource package #391

rynowak opened this issue Oct 8, 2015 · 3 comments
Assignees
Milestone

Comments

@rynowak
Copy link
Member

rynowak commented Oct 8, 2015

We need to integrate the new package with the renames and remove all the #pragma warning supressions. This will require follow up in EventNotification, MVC and EF as well as with our partner teams.

@rynowak rynowak added this to the 1.0.0-rc1 milestone Oct 8, 2015
@muratg
Copy link

muratg commented Oct 9, 2015

@CesarBS this is reacting to the naming changes in CoreCLR. The work would be to disable Pragma's @rynowak added, see what fails, and for each failure start to use the correct methods.It will have impact in other repos as well, so would potentially require changes in other repos as well. Feel free to sync-up with @Tratcher before you start.

@JunTaoLuo
Copy link
Contributor

Changes to EventNotification were made in aspnet/EventNotification/pull/29. Hosting changes, among others were made in /pull/423. There are no more #pragma warning suppressions in these repos but they remain in MVC. I'll open an issue there to track changes.

@JunTaoLuo
Copy link
Contributor

Nothing more to do here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants