Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

IFormFile.SaveAsAsync #610

Closed
Bartmax opened this issue Apr 5, 2016 · 4 comments
Closed

IFormFile.SaveAsAsync #610

Bartmax opened this issue Apr 5, 2016 · 4 comments

Comments

@Bartmax
Copy link

Bartmax commented Apr 5, 2016

I'm moving a RC1 project to RC2, i found every change but one.

IFormFile.SaveAsAsync looks like it's missing (i can't even find it on github history)

is this removed, moved, or something else?

Thanks

@davidfowl
Copy link
Member

It got removed because it was untestable. We added CopyTo and CopyToAsync (https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.Http.Features/IFormFile.cs#L61). You now own opening the file stream yourself.

@Bartmax
Copy link
Author

Bartmax commented Apr 5, 2016

Thank you. +1. Unfortunately I loved that method being out of the box.

@Bartmax Bartmax closed this as completed Apr 5, 2016
@davidfowl
Copy link
Member

I know but I like tests more.

@mostafamahran
Copy link

When I Identify Using Microsoft.AspNetCore.Http , the program can`t read it why

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants