Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Provide an overload of SignInManager.SignOut taking an authType #361

Closed
Praburaj opened this issue Feb 12, 2015 · 3 comments
Closed

Provide an overload of SignInManager.SignOut taking an authType #361

Praburaj opened this issue Feb 12, 2015 · 3 comments
Assignees
Milestone

Comments

@Praburaj
Copy link
Contributor

Currently when I say SignOut it specifically signs out the cookie middlewares that Identity wired up.

When I use OpenIdConnect with identity, to sign out from OpenIdConnect I ended up doing a

Response.SignOut("OpenIdConnect");

as in https://github.com/aspnet/MusicStore/blob/dev/src/MusicStore/Controllers/AccountController.cs#L442

@Praburaj Praburaj added the bug label Feb 12, 2015
@HaoK
Copy link
Member

HaoK commented Feb 12, 2015

This is sort of by design honestly, Identity is primarily concerned with only the main application cookie. To sign out other auth types, Response.SignOut("authType)" is correct. That said, we can add an overload that just routes it through as well.

@Praburaj
Copy link
Contributor Author

Having an overload will help using a familiar API for all signin/signout needs - as templates will use this. I remember we had this in Identity 2.0 so I thought it will be useful.

@rustd rustd added this to the 3.0.0-rc1 milestone Feb 16, 2015
@rustd rustd modified the milestones: 3.0.0-beta5, 3.0.0-beta4 Mar 23, 2015
@HaoK
Copy link
Member

HaoK commented May 11, 2015

Can revisit if we get more requests, don't really want to expose duplicate Security Authentication APIs

@HaoK HaoK closed this as completed May 11, 2015
@rustd rustd added the 3 - Done label Jun 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants