Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

GetUserId extension method doesn't honor IdentityOptions.ClaimsIdentity.UserIdClaimType #663

Closed
brockallen opened this issue Dec 6, 2015 · 10 comments
Assignees
Milestone

Comments

@brockallen
Copy link

Same for GetUserName. They're both hard coded to use the legacy SOAP/WS-* ClaimTypes enum.

@rustd rustd added this to the 3.0.0-rc2 milestone Dec 7, 2015
@rustd
Copy link

rustd commented Dec 7, 2015

Add this to the announcements repo.

@brockallen
Copy link
Author

I'm guessing you're not looking for a fix, so might I suggest adding these as extension methods to the VS template project and not into the core identity framework? In many projects the display name should not be the same as the username the user enters to login.

@leastprivilege
Copy link

really? I always say "good morning MICROSOFT/PRANAV" when I meet him him the hallway.

@MaximRouiller
Copy link

I'll have to greet him that way at the next Summit. ;-)

@HaoK
Copy link
Member

HaoK commented Dec 9, 2015

We are actually going to nuke this extension since it was only important in 2.0 because all the user manager APIs took user id, now that they take the user itself, its no longer needed

@brockallen
Copy link
Author

yay. the less people are forced to use certain claims types, the better. thx.

@HaoK
Copy link
Member

HaoK commented Dec 9, 2015

Gone 1c26e8f

@HaoK HaoK closed this as completed Dec 9, 2015
@HaoK HaoK added the 3 - Done label Dec 9, 2015
@HaoK HaoK reopened this Dec 9, 2015
@HaoK
Copy link
Member

HaoK commented Dec 9, 2015

Looks like we need to provide alternate sugar for the templates in some from before removing these

@HaoK
Copy link
Member

HaoK commented Jan 4, 2016

Going to remove all the identity claims principal extensions and add instance methods on SignInManager:

GetUserId/UserName/IsSignedIn...

Templates will need to be updated

@HaoK
Copy link
Member

HaoK commented Jan 14, 2016

2dade94

@HaoK HaoK closed this as completed Jan 14, 2016
@HaoK HaoK added 3 - Done and removed 2 - Working labels Jan 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants