Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

XML comment for IdentityUser.Id property is messed up #869

Closed
xperiandri opened this issue Jun 13, 2016 · 7 comments
Closed

XML comment for IdentityUser.Id property is messed up #869

xperiandri opened this issue Jun 13, 2016 · 7 comments
Assignees
Milestone

Comments

@xperiandri
Copy link

See

@MaximRouiller
Copy link

Misaligned.

@blowdart
Copy link
Member

@HaoK - missed :) Can you adjust?

@xperiandri
Copy link
Author

@xperiandri
Copy link
Author

@HaoK HaoK added this to the 1.0.0 milestone Jun 14, 2016
@HaoK HaoK self-assigned this Jun 14, 2016
@HaoK
Copy link
Member

HaoK commented Jun 14, 2016

7b3b362

@HaoK HaoK closed this as completed Jun 14, 2016
@xperiandri
Copy link
Author

I'm just looking at the comments to make OpenIddict comments having the same style.

@xperiandri
Copy link
Author

The style of description is inconsistent for
https://github.com/aspnet/Identity/blob/dev/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore/IdentityDbContext.cs#L51-L53
and
https://github.com/aspnet/Identity/blob/dev/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore/UserStore.cs#L105-L112

Which one will be agreed for entity type description?

  1. The type of entity objects.
  2. The type representing a entity.

And for primary key

  1. The type of the primary key for entityes1 and entityes2>.
  2. The type of the primary key for a entity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants