Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Dll property details tab does not show assembly info attribute #776

Closed
xqiu opened this issue Oct 17, 2014 · 2 comments
Closed

Dll property details tab does not show assembly info attribute #776

xqiu opened this issue Oct 17, 2014 · 2 comments

Comments

@xqiu
Copy link

xqiu commented Oct 17, 2014

  1. Have a cs file with following content in a projectK class library:
    [assembly: AssemblyTitle("testTitle")]
    [assembly: AssemblyDescription("test Discription")]
    [assembly: AssemblyConfiguration("")]
    [assembly: AssemblyCompany("test comany")]
    [assembly: AssemblyProduct("test product")]
    [assembly: AssemblyCopyright("test Copyright © .")]
    [assembly: AssemblyTrademark("test trademark")]
    [assembly: AssemblyCulture("")]
  2. KPM build and use windows explorer check the generated dll property.

Actual:
Defined assembly info are not shown in windows explorer property page details tab.

From: David Fowler
More like our use of roslyn, might need to specify something that isn't being specified right now.

From: Levi Broderick
The Explorer "Details" view is populated by the Win32 module manifest baked into the assembly. Normally csc.exe generates this Win32 manifest at compile time based on the assembly-level attributes it encounters. Perhaps Roslyn isn't doing this for some reason?

@troydai troydai self-assigned this Oct 29, 2014
@troydai
Copy link
Contributor

troydai commented Oct 29, 2014

It looks like the Roslyn doesn't generate the manifest during assembly emit based my experiment. If so, out builder needs to update the file properties on our own.

@troydai
Copy link
Contributor

troydai commented Oct 30, 2014

The root cause is because we don't set Win32 resource. Follow code snippet demonstrates a solution:

using (var fs = File.Create(filename))
using (var w32res = compilation.CreateDefaultWin32Resources(true, false, null, null))
{
    return compilation.Emit(peStream: fs, win32Resources: w32res);
}

@davidfowl davidfowl added this to the 1.0.0-beta2 milestone Oct 30, 2014
@troydai troydai closed this as completed Oct 30, 2014
@danroth27 danroth27 changed the title ProjectK dll property details tab does not show assembly info attribute Dll property details tab does not show assembly info attribute Jan 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants