Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Publish not trimming for -final packages #161

Closed
Tratcher opened this issue Jun 16, 2017 · 3 comments
Closed

Publish not trimming for -final packages #161

Tratcher opened this issue Jun 16, 2017 · 3 comments
Assignees
Milestone

Comments

@Tratcher
Copy link
Member

The -final .All package includes both versioned and final manifest files. E.g. aspnetcore-store-2.0.0-preview2-25756-linux-x64.xml and aspnetcore-store-2.0.0-preview2-final-linux-x64.xml.
The PublishWithAspNetCoreTargetManifest.targets file references the versioned manifests. These all reference versioned packages, which do not match the -final packages referenced by your app, so nothing gets trimmed.

@muratg @Eilon Preview2 blocking

@Tratcher Tratcher added this to the 2.0.0-preview2 milestone Jun 16, 2017
@Tratcher Tratcher self-assigned this Jun 16, 2017
@Eilon Eilon modified the milestones: 2.0.0, 2.0.0-preview2 Jun 18, 2017
@Eilon
Copy link
Member

Eilon commented Jun 18, 2017

Moving to RTM milestone because we did the workaround for Preview2.

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Jun 19, 2017

This issue is masked in 2.0.0 by #143 which means even without any changes, trimming should work correctly for the -final package. However, we still need to fix this to remove the redundant manifests in the package. Also, this will break new builds of preview2. Note that the issue actually lies with the build scripts in Coherence-Signed, there won't be changes in this repository.

@JunTaoLuo
Copy link
Contributor

The trimming issue has been fixed as part of #167 in preview2. The duplication is fixed by https://github.com/aspnet/Coherence-Signed/pull/588 in dev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants