Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Big Rock: View Compilation Tool for Pages #6018

Closed
DamianEdwards opened this issue Mar 23, 2017 · 6 comments
Closed

Big Rock: View Compilation Tool for Pages #6018

DamianEdwards opened this issue Mar 23, 2017 · 6 comments

Comments

@DamianEdwards
Copy link
Member

We'll need to embed some more meta-data in order to make the pages work

@DamianEdwards
Copy link
Member Author

@Eilon @rynowak @pranavkm this needs triaging/assigning.

@rynowak
Copy link
Member

rynowak commented Apr 3, 2017

@pranavkm - I'm envisioning an IR pass as part of MVC's extensibility that will extract the relevant information and put it in the 'manifest'.

Then this can be uniform for views and pages. Each one produces a generated class in one .cs file, and a manifest (assembly level attributes) in another .cs file.

This has the benefit that everything is now uniform, pages/views and compilation/precompilation.

When you load a 'precompiled' assembly, the set of views/pages are determined by the manifest.
When you load a 'compiled' assembly the set of views/pages are also determined by the manifest.

@rynowak rynowak added this to the 2.0.0-preview1 milestone Apr 3, 2017
@rynowak
Copy link
Member

rynowak commented Apr 3, 2017

@pranavkm - please look at this after finishing up the URL generation stuff.

@rynowak rynowak changed the title Make MVC view compilation tool work for Razor Pages Big Rock: View Compilation Tool for Pages Apr 4, 2017
@DamianEdwards
Copy link
Member Author

@pranavkm is this done now via 8ed5510?

@pranavkm
Copy link
Contributor

@DamianEdwards it is now that aspnet/MvcPrecompilation@7f4aa60 is checked in.

@rynowak
Copy link
Member

rynowak commented Apr 19, 2017

🍺 🌵 🏅 🔥

@rynowak rynowak moved this from Working to Done in Razor Pages 2.0.0-preview1 Apr 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

3 participants