Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Exceptions thrown from Views when run from a net461 application do not contain line numbers or file info #6356

Closed
NTaylorMullen opened this issue Jun 2, 2017 · 3 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Member

The reason why this occurs is because our CSharpCompiler.EmitOptions unconditionally sets the debugInformationFormat to the pdb format (can't be understood by .net framework). We should consider auto-detecting the current framework and set the PDB format accordingly.

Note that this blocks the RuntimeErrorAreListedByErrorPageMiddleware test from passing on net461.

This issue can be closed as a duplicate of dotnet/extensions#235 if we complete that one first. Leaving this issue here in-case we decide to go for a non-portable-pdb approach; the sdk will be moving to non-portable pdbs for desktop applications anyways so this may be more consistent with the rest of the system.

@NTaylorMullen
Copy link
Member Author

/cc @anurse @DamianEdwards FYI if you don't see line numbers in your views when app building net461.

@analogrelay
Copy link
Contributor

I had actually noticed this, thanks for the heads-up :)

@Eilon Eilon added this to the 2.0.0 milestone Jun 6, 2017
@pranavkm
Copy link
Contributor

Fixed in e5da44a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants