Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

RazorViewEngineOptions shouldn't be a property of MvcOptions #986

Closed
pranavkm opened this issue Aug 12, 2014 · 3 comments
Closed

RazorViewEngineOptions shouldn't be a property of MvcOptions #986

pranavkm opened this issue Aug 12, 2014 · 3 comments

Comments

@pranavkm
Copy link
Contributor

This was based off a conversation with @loudej when we were discussing MvcRazorHost. The idea is RazorViewEngine is the default implementation we configure, but shouldn't be tied to MvcOptions. Instead it would be a separate top level options type that can be configured independently.

.Setup<MvcOptions>(options => { })
.Setup<RazorOptions>(options => {});
@yishaigalatzer
Copy link
Contributor

@pranavkm @loudej can someone explain why we want it this way? Putting things in MVC options makes it easier to find them, and since the view engine is tightly coupled to MVC, it's not really clear to me why the separation.

is it to make Web Pages feel disconnected from MVC when we implement it or is there another idea behind this?

@yishaigalatzer yishaigalatzer added this to the 6.0.0-beta1 milestone Aug 27, 2014
@pranavkm
Copy link
Contributor Author

ViewLocationExpanders currently located on MvcOptions also needs to be part of this.

@pranavkm
Copy link
Contributor Author

pranavkm commented Oct 9, 2014

Fixed as part of ad8ab4b

@pranavkm pranavkm closed this as completed Oct 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants