Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Extensible directives should output typenames with global:: #1128

Closed
NTaylorMullen opened this issue Mar 27, 2017 · 3 comments
Closed

Extensible directives should output typenames with global:: #1128

NTaylorMullen opened this issue Mar 27, 2017 · 3 comments
Assignees

Comments

@NTaylorMullen
Copy link
Member

There are several instances where we generate design time code for extensible directives. For example: @stringDirective Foo will generate a design time bit that looks like:

((System.Action)(() => {
 System.Object __typeHelper = "Foo";
}))();

We should add a global:: to System.Object.

@Eilon
Copy link
Member

Eilon commented Mar 29, 2017

And to System.Action, right?

@NTaylorMullen
Copy link
Member Author

And to System.Action, right?

Of course 😄

@rynowak
Copy link
Member

rynowak commented Apr 6, 2017

Fixed by 0cb7ae7

@rynowak rynowak closed this as completed Apr 6, 2017
@rynowak rynowak self-assigned this Apr 6, 2017
@rynowak rynowak added 3 - Done and removed 1 - Ready labels Apr 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants