Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

[Breaking change] Parameter was renamed on OpenIdConnectHandler.HandleSignOutAsync #1030

Closed
javiercn opened this issue Nov 8, 2016 · 3 comments
Assignees
Milestone

Comments

@javiercn
Copy link
Member

javiercn commented Nov 8, 2016

V1:
protected override async Task HandleSignOutAsync(SignOutContext signout)
V2:
protected override async Task HandleSignOutAsync(SignOutContext context)

https://github.com/aspnet/Security/blob/1.0.0/src/Microsoft.AspNetCore.Authentication.OpenIdConnect/OpenIdConnectHandler.cs#L143
https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication.OpenIdConnect/OpenIdConnectHandler.cs#L153

It breaks on classes overriding the method and calling base with named arguments

@javiercn
Copy link
Member Author

javiercn commented Nov 8, 2016

@Eilon

@javiercn javiercn added this to the 1.1.0 milestone Nov 8, 2016
@javiercn javiercn added the bug label Nov 8, 2016
@davidfowl
Copy link
Member

We might want to relax this one...

@Eilon
Copy link
Member

Eilon commented Nov 8, 2016

Eh, let's fix the breaking change. The old parameter name wasn't awful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants