Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

OpenIdConnectHandler.AuthenticateAsync should not throw SecurityTokenException #351

Closed
brentschmaltz opened this issue Jul 9, 2015 · 1 comment
Closed

OpenIdConnectHandler.AuthenticateAsync should not throw SecurityTokenException #351

brentschmaltz opened this issue Jul 9, 2015 · 1 comment
Assignees
@Tratcher
Labels
3 - Done bug OIDC
Milestone
1.0.0-rc1

Comments

@brentschmaltz
Copy link
Contributor

If message.Error is ! null, the OIDC handler throws SecurityTokenException, it should throw OpenIdConnectProtocolException. Other SecurityTokenExceptions should be considered as well.
@Eilon Eilon added the bug label Jul 30, 2015
@Eilon Eilon added this to the 1.0.0-beta8 milestone Jul 30, 2015
@Eilon Eilon modified the milestones: 1.0.0 backlog, 1.0.0-beta8 Aug 27, 2015
@Eilon Eilon modified the milestones: 1.0.0-rc1, 1.0.0 backlog Sep 24, 2015
@Tratcher
Copy link
Member

This was already fixed by #55 where we changed many of these exceptions to AuthenticationResult.Failed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
3 - Done bug OIDC
Projects
None yet
Milestone
1.0.0-rc1
Development

No branches or pull requests
3 participants
@Eilon @Tratcher @brentschmaltz