Exception when using the new DI activated options style cookie auth

[borgdylan]

After updating to newest security packages, I get the following exception:

System.AggregateException: One or more errors occurred ---> System.ArgumentNullException: Argument cannot be null.
Parameter name: provider
  at Microsoft.Framework.DependencyInjection.ServiceProviderExtensions.GetService[ILoggerFactory] (IServiceProvider provider) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Builder.RouterMiddleware.EnsureLogger (Microsoft.AspNet.Http.HttpContext context) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Builder.RouterMiddleware+<Invoke>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Security.Infrastructure.AuthenticationMiddleware`1+<Invoke>d__1[Microsoft.AspNet.Security.Cookies.CookieAuthenticationOptions].MoveNext () [0x00000] in <filename unknown>:0 
  --- End of inner exception stack trace ---
 --> (Inner exception 0) System.ArgumentNullException: Argument cannot be null.
Parameter name: provider
  at Microsoft.Framework.DependencyInjection.ServiceProviderExtensions.GetService[ILoggerFactory] (IServiceProvider provider) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Builder.RouterMiddleware.EnsureLogger (Microsoft.AspNet.Http.HttpContext context) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Builder.RouterMiddleware+<Invoke>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Security.Infrastructure.AuthenticationMiddleware`1+<Invoke>d__1[Microsoft.AspNet.Security.Cookies.CookieAuthenticationOptions].MoveNext () [0x00000] in <filename unknown>:0 

[borgdylan]

This bug does not let my app run at all as all requests return an internal server error.

[Tratcher]

I don't think this is related to the security middleware changes, the exception is coming from here:
https://github.com/aspnet/Routing/blob/dev/src/Microsoft.AspNet.Routing/RouterMiddleware.cs#L61

@yishaigalatzer Do you know where this logging resolution pattern came from? It's not how we do it anywhere else. See CookieAuthMiddleware & Extensions for a better example.

[Tratcher]

@borgdylan It looks like RequestServices is null. Do you still have a call to UseServices in your startup?

Also: aspnet/Hosting#88

[Tratcher]

@HaoK

[borgdylan]

I am no longer calling ContainerExtensions.UseServices. I am using ConfigureServices in my Startup class. Should I revert back for now?

[HaoK]

Using ConfigureServices is fine, but you still need UseServices to actually use the services you configured

[HaoK]

The UseServices() with no parameters is what you want to use to automatically use the Configured services

[borgdylan]

That fixed the issue. Thanks

[Tratcher]

I'm still going to open a bug against RouterMiddleware, logging shouldn't be resolved that way.

[borgdylan]

Indeed. Adding an ILoggerFactory in ConfigureServices still causes the exception without UseServices