Skip to content
This repository has been archived by the owner on Apr 20, 2019. It is now read-only.

Add new sample (Blazor Excel) #372

Closed
Lupusa87 opened this issue Jan 13, 2019 · 11 comments
Closed

Add new sample (Blazor Excel) #372

Lupusa87 opened this issue Jan 13, 2019 · 11 comments
Assignees
Labels
Community Page Add to the Community Page. 🚀 Enhancement Enhance the topic
Projects

Comments

@Lupusa87
Copy link
Contributor

If you like please add this to samples list.

https://lupblazordemos.z13.web.core.windows.net/ExcelPage

https://github.com/Lupusa87/BlazorExcel

untitled

@guardrex guardrex self-assigned this Jan 14, 2019
@guardrex guardrex added the 🚀 Enhancement Enhance the topic label Jan 14, 2019
@guardrex guardrex added this to To do in Blazor.Docs via automation Jan 14, 2019
@guardrex guardrex added this to the 0.8.0 milestone Jan 14, 2019
@guardrex guardrex added the Community Page Add to the Community Page. label Feb 1, 2019
@guardrex
Copy link
Collaborator

guardrex commented Feb 1, 2019

@Lupusa87 I don't think we can add this because "Excel" is a registered trademark of Microsoft Corp. You could change it to something like "Blazor Spreadsheet" or "Blazor Calc" ... something that won't get us locked up! 👮🚓 lol

@Lupusa87
Copy link
Contributor Author

Lupusa87 commented Feb 2, 2019

Sorry I did not thought about this.

I have updated name as you suggested.

https://lupblazordemos.z13.web.core.windows.net/SpreadsheetPage

https://github.com/Lupusa87/BlazorSpreadsheet

Thank you

@lohithgn
Copy link
Contributor

lohithgn commented Feb 2, 2019

@Lupusa87 instead of asking @guardrex to update the community samples page - you should do the following:

  • fork the Blazor.Docs repo
  • update the community samples with your addition
  • create a PR

@guardrex will then just merge it to live … that's what most of us do when we need to add our samples to community samples page. Per se - we don't open an issue for this :)

hope this helps

@Lupusa87
Copy link
Contributor Author

Lupusa87 commented Feb 2, 2019

I have another new samples too, where should I open new issues here or in https://github.com/aspnet/Docs/tree/master/aspnetcore/razor-components?

For example https://lupblazordemos.z13.web.core.windows.net/PerformanceChartPage

@guardrex
Copy link
Collaborator

guardrex commented Feb 2, 2019

It's no serious bother @lohithgn ... only takes a few minutes. Besides, I frequently need to update the format and language to conform to our guidelines, so I end up having to edit most of them.

@Lupusa87 ... thanks ... I'll get that in there in a few minutes. Thanks.

We narrowly avoided getting the 🔪 there! lol ...We don't want to invoke the wrath of CELA attorneys! 😨

@lohithgn
Copy link
Contributor

lohithgn commented Feb 2, 2019

still @guardrex - you can utilize those minutes for real issues :)

@Lupusa87
Copy link
Contributor Author

Lupusa87 commented Feb 2, 2019

@lohithgn Thank you for advise, you are right but I don't have big experience in PRs :) Will try.

For now it is not clear where should I do this, because as I see repo is changing.

@guardrex
Copy link
Collaborator

guardrex commented Feb 2, 2019

@lohithgn I'm SURE that the .NET Foundation and MS management would agree! 😀 $$$ 💰 $$$

The plan is that the Community page is going to move, but not at the moment. Dan's working on that and will let us know. For now, we'll just keep updating here on Blazor.Docs.

@lohithgn
Copy link
Contributor

lohithgn commented Feb 2, 2019

@Lupusa87 if you go to this page - https://blazor.net/community.html … it has a link called Improve this doc. That will point you to the repo. Even if the team changes the repo, the link will always point to the right place. That's what we all do. Trivial thing like this should be no brainer.

@guardrex
Copy link
Collaborator

guardrex commented Feb 2, 2019

Yes ... the format for each section is easy to see now because there are so many entries. Just copy and paste one of the others in the same section and then modify it with the correct title, links, description.

@lohithgn
Copy link
Contributor

lohithgn commented Feb 2, 2019

may be i should do a video … hmmm … something for my backlog ;)

Blazor.Docs automation moved this from To do to Done Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Page Add to the Community Page. 🚀 Enhancement Enhance the topic
Projects
Blazor.Docs
  
Done
Development

No branches or pull requests

3 participants