Skip to content
This repository has been archived by the owner on Dec 8, 2018. It is now read-only.

Rename ErrorHandler and its associated types/extensions #43

Closed
kevinchalet opened this issue Oct 15, 2014 · 3 comments
Closed

Rename ErrorHandler and its associated types/extensions #43

kevinchalet opened this issue Oct 15, 2014 · 3 comments
Assignees
@kichalla
Labels
3 - Done enhancement
Milestone
1.0.0-beta8

Comments

@kevinchalet
Copy link

As stated here by @Tratcher (aspnet/Security#55 (comment)), the "ErrorHandler is just for unhandled exceptions". This general/generic name is terribly confusing, as it gives you the impression that it's meant to handle every kind of errors and not just uncaught exceptions.

ExceptionHandler, UnhandledExceptionHandler or UncaughtExceptionHandler might be better names.
@Eilon
Copy link
Member

Eilon commented Jul 10, 2015

Need to come up with some names...

  • ErrorHandler
    • Needs to say something about being specifically about exceptions
  • ErrorPage
    • Needs to say something about being specifically about exceptions
    • Also needs to say something about being for development mode only

@Eilon Eilon added this to the 1.0.0-beta7 milestone Jul 10, 2015
@Eilon Eilon mentioned this issue Jul 10, 2015
Closed
@Eilon Eilon modified the milestones: 1.0.0-beta7, 1.0.0-beta8 Aug 14, 2015
@kichalla
Copy link
Member

kichalla commented Sep 2, 2015

  • ErrorHandler is to be named to UseExceptionHandler
  • ErrorPage is to be named to UseDeveloperExceptionPage

@kichalla
Copy link
Member

kichalla commented Sep 9, 2015

c46615d

@kichalla kichalla closed this as completed Sep 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kichalla kichalla

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
4 participants
@Eilon @glennc @kichalla @kevinchalet