Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

"kpm /?" doesn't print out help for kpm #393

Closed
maumar opened this issue Jun 26, 2014 · 10 comments
Closed

"kpm /?" doesn't print out help for kpm #393

maumar opened this issue Jun 26, 2014 · 10 comments
Assignees
Milestone

Comments

@maumar
Copy link

maumar commented Jun 26, 2014

This is a common way for people to ask for help (and works for kvm, for instance). However kpm doesn't accept this format.

This is what gets printed at the moment:

"Calls one batch program from another.
CALL [drive:][path]filename [batch-parameters]
batch-parameters Specifies any command-line information required by the
batch program.
If Command Extensions are enabled CALL changes as follows:
CALL command now accepts labels as the target of the CALL. The syntax
is:
CALL :label arguments
...
"

@davidfowl
Copy link
Member

2 things:

  1. maybe you have an older version of kpm
  2. We don't support / for args, just - and -- because its more *nix friendly. / could be the start of the path as the argument value so we removed it as it causes problems on *nix

@ChengTian
Copy link
Contributor

@davidfowl , I just checked with latest kpm. kpm /? is displaying help information of CALL because we get CALL ... /? after string concatenation in kpm.cmd and /? takes over the control. I can fix it soon.

@davidfowl
Copy link
Member

What happens on osx and linux?

@Praburaj
Copy link
Contributor

This needs to be fixed for both k and kpm

@ChengTian
Copy link
Contributor

This change was reverted. Reopen here.

@Eilon
Copy link
Member

Eilon commented Nov 19, 2014

Running any of the command line tools (k, kpm, kvm) without any arguments prints the help. They also all support -?, -h, --help to show the help. Some also support the format kpm help <command> for detailed command information.

@davidfowl @ChengTian @muratg @glennc do we need anything more here? We're not planning to support / as a command separator so I don't think there's anything left to do...

@ChengTian
Copy link
Contributor

kpm /? should show invalid argument '/?', instead of help information of cmd.exe.

Since kpm.cmd is called with cmd.exe /C kpm.cmd <KPM_ARGS> while /? has a super high priority in the eyes of cmd.exe, /? makes cmd.exe show help information and kpm doesn't get called. There is a PR pending for this bug and I will merge it after adding functional tests.

@Praburaj
Copy link
Contributor

Yes as long as it does not show weird stuff on typing /? it is enough.

@muratg muratg added this to the 1.0.0-rc1 milestone Dec 5, 2014
@muratg
Copy link
Contributor

muratg commented Dec 5, 2014

We need to get this in for RC

@ChengTian
Copy link
Contributor

This is not true any more after we reduce scripts in this commit 29e6e8a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants