Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

kpm pack should not include bin and obj #737

Closed
naianacampos opened this issue Oct 10, 2014 · 6 comments
Closed

kpm pack should not include bin and obj #737

naianacampos opened this issue Oct 10, 2014 · 6 comments
Assignees
Milestone

Comments

@naianacampos
Copy link

1.Create vNext Empty WAP
2.Publish

[observed]
published

[Expected]
kpm pack should not include bin and obj

@davidfowl
Copy link
Member

Yes, that's a bug in our templates. We exclude the wwwroot by default which removes the original defaults. We should move more defaults to the template

@glennc glennc added this to the 1.0.0-rc1 milestone Oct 15, 2014
@glennc glennc added the bug label Oct 15, 2014
@davidfowl davidfowl modified the milestones: 1.0.0-rc1, 1.0.0-beta2 Nov 3, 2014
@davidfowl davidfowl modified the milestones: 1.0.0-beta2, 1.0.0-rc1 Dec 19, 2014
@davidfowl
Copy link
Member

We're going to be adding 2 new properties:

{
   "builtinCode": "**/*.cs",
   "builtinExclude": ["bin/", "obj"]
}

These will be combined with the default code and exclude

@Praburaj
Copy link
Contributor

Praburaj commented Jan 7, 2015

With latest VS builds I notice bin and obj folder are created in the ../artifacts/ folder rather than in the application folder itself. So publish does not include the bin and obj folders by default. I notice if user switches between command line (kpm build on command line creates bin folder in application folder) and VS (publish) then this reproduces.

@ChengTian
Copy link
Contributor

To fix the bug reported at the beginning of this thread, we should also have

{
   "builtinPackExclude": ["bin", "obj", "**/.*/**"]
}

, which will eventually be builtinBundleExclude after kpm renaming. I'll work on this after kpm renaming is checked in.

@davidfowl davidfowl reopened this Mar 19, 2015
@davidfowl
Copy link
Member

This is fixed now /cc @troydai right?

@troydai
Copy link
Contributor

troydai commented Mar 19, 2015

Yup. Verified locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants