Resx files are included without honoring exclude

[Tragetaschen]

Steps to reproduce:

• Create a vnext class library
• Add "bin" to both exclude and packExclude
• Add a *.resx file
• kpm build (works)
• kpm pack (works)
• kpm build

error CS1508: Resource identifier 'ClassLibrary1.Resources.resources' has already been used in this assembly

This is due to the resx file being copied into the bin folder by pack and then being picked up by ResxResourceProvider.GetResources

[muratg]

@ChengTian Can you have a look?

[ChengTian]

Verified. ResxResourceProvider.GetResources doesn't honor exclude pattern.

https://github.com/aspnet/KRuntime/blob/dev/src/Microsoft.Framework.Runtime.Roslyn/ResxResourceProvider.cs#L19

[ChengTian]

@troydai , do you have time to look at this issue? I guess we can fix it with your nice file globbing library 😄

[troydai]

I'm assigning this issue to @victorhurdugaci. The code in question will be removed eventually, and it deals with code searching incorrectly. Today the ProjectFilesCollection already returns the correct set of resources file. @victorhurdugaci will begin using it in the upcoming changes. Therefore the bug will be fixed naturally in the process.

/cc @muratg

[victorhurdugaci]

This is fixed, not sure why GitHub didn't resolve it.