Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small semicolon inconsistency fix for some minifiers #74

Closed
funkynicco opened this issue Jan 21, 2018 · 0 comments
Closed

Small semicolon inconsistency fix for some minifiers #74

funkynicco opened this issue Jan 21, 2018 · 0 comments
Assignees
Labels
3 - Done bug cost: S Will take up to 2 days to complete
Milestone

Comments

@funkynicco
Copy link

There is a missing semicolon for the variable declarations on lines 124-131 (as of current date of writing this, latest commit being e7444c9).

This breaks some minifiers which makes the minified code as following example:

var x=function(){}if(!y)

This generates "unexpected if".

If anyone is able to fix this it would be great (theres a number of minifiers that does not build up an AST syntax tree to determine what the code actually does).

If figured opening an issue on the matter is less effort overall than forking and doing a pull request for a very tiny fix.

Thanks.

@mkArtakMSFT mkArtakMSFT added this to the 3.2.7 milestone Feb 12, 2018
@kichalla kichalla added the cost: S Will take up to 2 days to complete label Mar 6, 2018
@Eilon Eilon modified the milestones: 3.2.7, 3.2.8 Mar 13, 2018
@danroth27 danroth27 modified the milestones: 3.2.8, 3.2.9 Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done bug cost: S Will take up to 2 days to complete
Projects
None yet
Development

No branches or pull requests

5 participants