Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

LibUV should use win8-arm as the RID #15

Closed
davidfowl opened this issue Nov 3, 2016 · 9 comments
Closed

LibUV should use win8-arm as the RID #15

davidfowl opened this issue Nov 3, 2016 · 9 comments
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

It currently places WinArm32 assets under win7-arm that is not a valid RID/platform configuration.

/cc @gkhanna79

Moved from https://github.com/dotnet/corefx/issues/13311

@muratg
Copy link
Contributor

muratg commented Nov 3, 2016

I thought there were other problems with running kestrel on arm, but perhaps I'm wrong. cc @moozzyk

@moozzyk
Copy link
Contributor

moozzyk commented Nov 3, 2016

libuv works fine on windows arm. It originally used win10-arm but I had to move it to win7-arm or to avoid issues during publish (aspnet/KestrelHttpServer#340 + linked bugs). Note that the publish there was the dnu publish so things might work now. Hard to verify since AFAIK there is no runtime for arm at the moment.

@Petermarcu
Copy link
Contributor

When do we think we can get a fix for this? I'd love to be able to do some hacking on Win10 IoT :)

@Petermarcu
Copy link
Contributor

Simple change I think. I don't really know how to build and validate. #16

@Petermarcu
Copy link
Contributor

I also wasn't sure what branch is the right one to go against for vNext.

@muratg muratg added this to the 1.2.0 milestone Nov 4, 2016
@moozzyk
Copy link
Contributor

moozzyk commented Nov 10, 2016

This has been fixed in both repos now.

@moozzyk moozzyk closed this as completed Nov 10, 2016
@Petermarcu
Copy link
Contributor

Thanks!

@gkhanna79
Copy link

But #16 seems to be open. Which PRs fixed them and where?

@moozzyk
Copy link
Contributor

moozzyk commented Nov 10, 2016

@gkhanna79 - I rebased on changes I made to update libuv to 1.10.0. This PR was pushed as a16eed2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants