Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Codes should be supported in templates #5405

Closed
Rick-Anderson opened this issue Oct 4, 2017 · 14 comments
Closed

QR Codes should be supported in templates #5405

Rick-Anderson opened this issue Oct 4, 2017 · 14 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@Rick-Anderson
Copy link
Contributor

Enabling QR Code generation for authenticator apps

That should be supported in the templates like SMS 2FA used to be.

requested by customer in Enabling QR Code generation for authenticator apps comments

@DamianEdwards
Copy link
Member

This requires additional APIs in the platform (.NET Core) or external libraries. I don't wish to include the JS library in the templates just for the QR code. Similarly I don't want to include a 3rd-party server-side drawing library just to enable it either (e.g. ImageSharp.Drawing).

System.Drawing is being made available for .NET Core for compatibility purposes so we could investigate using it for this purpose.

@Eilon
Copy link
Member

Eilon commented Oct 6, 2017

cc @blowdart

@blowdart
Copy link
Contributor

blowdart commented Oct 6, 2017

System.Drawing is not suitable, as it's a straight port of the "do not use in a web app code"

@DamianEdwards
Copy link
Member

Yeah, but people do anyway. Always have, always will. There isn't any plan for a System.* replacement AFAIK, so if we don't use it, we need to make something custom (not out of the question given it's just a QR code) or look at ImageSharp.Drawing.

@DamianEdwards
Copy link
Member

ping @muratg who was looking at this too

@blowdart
Copy link
Contributor

blowdart commented Oct 6, 2017

But we shouldn't.

Anyway it's not cross platform.

@DamianEdwards
Copy link
Member

It is? I couldn't remember if they limited that one to Windows or not. Many packages in the "Windows compat pack" actually have *nix implementations included as well.

@blowdart
Copy link
Contributor

blowdart commented Oct 6, 2017

I think so, either way, we don't want to encourage the use of something that may leak memory and handles.

@DamianEdwards
Copy link
Member

@blowdart so serious 😉

Well then, given ImageSharp.Drawing is still only in beta, we're a bit stuck unless we want to go the route of doing a custom QR code generator.

@blowdart
Copy link
Contributor

blowdart commented Oct 6, 2017

We are, so we stick with the current situation IMO

@Eilon
Copy link
Member

Eilon commented Mar 5, 2018

Moving this to 2.2.0.

@mkArtakMSFT
Copy link
Member

@blowdart, moving this out to 3.0 as I don't think this is a priority for 2.2

@aspnet-hello aspnet-hello transferred this issue from aspnet/Templating Dec 17, 2018
@aspnet-hello aspnet-hello added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Dec 17, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0-preview1 milestone Dec 17, 2018
@Eilon Eilon modified the milestones: 3.0.0-preview1, 3.0.0-preview2 Dec 18, 2018
@mkArtakMSFT
Copy link
Member

Closing this as it seems we won't be able to do this in the near future.

@Rick-Anderson
Copy link
Contributor Author

@mkArtakMSFT can we schedule this for 3.1?

@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

6 participants