Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: IDapperRepository Execute & ExecuteAsync methods Return Value #2290

Closed
shike-z opened this issue Jul 4, 2017 · 2 comments
Closed
Milestone

Comments

@shike-z
Copy link
Contributor

shike-z commented Jul 4, 2017

Hi, @osoykan @hikalkan

The Execute & ExecuteAsync methods are void.
Would you modify the return value of the two methods to return the dapper's return value.

public override int Execute(string query, object parameters = null)
{
    return Connection.Execute(query, parameters, ActiveTransaction);
}

public override Task<int> ExecuteAsync(string query, object parameters = null)
{
    return Connection.ExecuteAsync(query, parameters, ActiveTransaction);
}
@osoykan
Copy link
Contributor

osoykan commented Jul 6, 2017

PR is opened #2297

@hikalkan
Copy link
Member

resolved with #2297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants