Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage #3740

Closed
Mardoxx opened this issue Aug 12, 2018 · 4 comments
Closed

Test coverage #3740

Mardoxx opened this issue Aug 12, 2018 · 4 comments

Comments

@Mardoxx
Copy link
Contributor

Mardoxx commented Aug 12, 2018

Very sparse in places.

@natiki
Copy link
Contributor

natiki commented Aug 13, 2018

So why not contribute some additional tests? A PR is always welcome.

@Mardoxx
Copy link
Contributor Author

Mardoxx commented Aug 14, 2018

I posted this here so it can be tracked, not as a personal insult to maintainers 😭

@ismcagdas
Copy link
Member

@Mardoxx we didn't think like that but there should be some metrics or you should specify some parts of the framework that doesn't have unit tests.

Otherwise it seems impossible to close this issue :).

@natiki
Copy link
Contributor

natiki commented Aug 15, 2018

@Mardox I am sure they are aware of how much coverage there is ;-). Why not scout around on https://github.com/marketplace and see if you can find something that is free and can be integrated into the CI? Or look at commercial tools like https://www.jetbrains.com/dotcover/ as I am sure that:

a) The maintainers own a copy
b) Could convince JetBrains to provide a free copy etc.

and integrate that.

I also note that Hangfire uses https://codecov.io/ and it is free for open source projects.

@hikalkan hikalkan closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants