Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript generation error? #4935

Closed
gpcaretti opened this issue Oct 18, 2019 · 1 comment
Closed

Javascript generation error? #4935

gpcaretti opened this issue Oct 18, 2019 · 1 comment

Comments

@gpcaretti
Copy link
Contributor

Versions

  • Abp 4.10.0
  • .Net Framework 4.6.2

Description of the possible error

After the rename of Get, GetAll, Create, Update and Delete with the postfix Async, automatic generation of javascript continue reporting ajax call with the old names, and they works.
Eg.

    serviceNamespace.get = function(input, ajaxParams) {
        return abp.ajax($.extend({
            url: abp.appPath + 'api/services/app/user/Get',
            type: 'POST',
            data: JSON.stringify(input)
        }, ajaxParams));
    };

    serviceNamespace.getAll = function(input, ajaxParams) {
        return abp.ajax($.extend({
            url: abp.appPath + 'api/services/app/user/GetAll',
            type: 'POST',
            data: JSON.stringify(input)
        }, ajaxParams));
    };
...

I don't know if it was wanted or if it is an oversight, but I would have expected to see calls with the 'Async' postfix : serviceNamespace.getAllAsync, etc., to be more coherent with server side refactoring.

@maliming
Copy link
Member

see
#2441 (comment)
#2514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants