-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Angular v9 #5272
Comments
@maxkol thank you for creating the issue. We can upgrade Angular template to v9 with the next version. |
@ismcagdas thank you |
@maxkol hard to say. I haven't checked the breaking changes and major changes in Angular 9 yet. |
I believe we can wait for 9.1 :) |
Hello, |
@kingemma Have you found a solution for this? |
We're also running into the same now, if anyone has a solution or suggestions. |
@bvdwalt recently released v6.0 of https://github.com/aspnetboilerplate/abp-ng2-module. Could you upgrade your project accordingly ? Basically;
|
Hi @ismcagdas, my issue is more to do with importing the abp namespace found in "abp-web-resources/Abp/Framework/scripts/abp.d.ts" which is in the npm package "abp-web-resources" and not in abp-ng2-module. So I don't think this will help me. |
Could you create a new issue and explain your problem ? If you have any error message, please also share it. |
|
same problem, just create clean angular 9 project, add abp-ng2-module, abp-web-resources, add in angular.json scripts "node_modules/abp-web-resources/Abp/Framework/scripts/abp.js", first it will not resolve abp namespace, example if you are using
so if someone did manage to set up with angular 9 latest abp-ng2-module 6.0 with abp-web-resources successfully please share. |
This might work;
|
It still doesn't work for me. src/root.module.ts:77:12 - error TS2304: Cannot find name 'abp'. 77 return abp.localization.currentLanguage.name && abp.localization.currentLanguage.name !== 'en-US' 77 return abp.localization.currentLanguage.name && abp.localization.currentLanguage.name !== 'en-US' 85 return abp.localization.currentLanguage.name |
If you can share a reproduction project, we can take a look. |
https://drive.google.com/file/d/138MdT4fzo2JjG2Vb-clikJeX5LzYz5rs/view?usp=sharing [Updated] I found my mistake and got other errors, lol. I did roleback all updating and did it again step by step. When I enable Ivy to compile, it compiles successfully, but the website can be loaded because there is an error in console. core.js:4061 ERROR Error: Uncaught (in promise): TypeError: Cannot read property 'id' of undefined |
@toanml I have tried but couldn't run your project. It keeps throwing error below;
|
@ismcagdas please only run project angular, I haven't knew why throw that exception yet. |
This worked for me to resolve Add the following to your typeRoots in tsconfig.json create a ./types folder in same folder as tsconfig.json
|
Oh, unfortunate this got moved from yesterdays 5.6 release to the next one, I finally wanted to switch to IVY. |
Waiting for #5452 |
Resolved via aspnetboilerplate/module-zero-core-template@c50d244 |
that's the solution? |
@ikliapchuk not just that. You also need to update abp-ng2-module to 6.0. |
@PrinceMasalawala I suggest you to use https://update.angular.io/. Also update all NPM packages to their latest version. IF you face any problem, please create a new issue and we will try to help you. |
that's it, thanks |
Thank you @clavamantock for this solution! was fighting with issue long hours until tried this one |
I love you. |
https://blog.angular.io/version-9-of-angular-now-available-project-ivy-has-arrived-23c97b63cfa3
The text was updated successfully, but these errors were encountered: