Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetNotifiers should not use unlimited string #6482

Closed
dolphinsd opened this issue Jun 27, 2022 · 1 comment · Fixed by #6544
Closed

TargetNotifiers should not use unlimited string #6482

dolphinsd opened this issue Jun 27, 2022 · 1 comment · Fixed by #6544
Assignees
Milestone

Comments

@dolphinsd
Copy link

Sql Server and other database are not very efficient if you use type: "nvarchar(max)",

Your just added a new column to AbpUserNotifications and AbpNotifications, TargetNotifiers

There is not reason to have it unlimited length! It slows down a potentially large table
Here you read about it at
https://www.sqlshack.com/varcharmax-data-type-walkthrough-and-its-comparison-with-varcharn-in-sql-server/

https://github.com/aspnetboilerplate/aspnetboilerplate/blob/669663a18c13674a4d1b2bb863510257559a2eab/src/Abp/Notifications/UserNotification.cs

@ismcagdas ismcagdas added this to the v7.4 milestone Jun 28, 2022
@ismcagdas
Copy link
Member

@dolphinsd thanks, we can limit the lenght of the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants