Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: export servlets into seperate (sub)package #31

Closed
GoogleCodeExporter opened this issue Mar 24, 2015 · 3 comments
Closed

Enhancement: export servlets into seperate (sub)package #31

GoogleCodeExporter opened this issue Mar 24, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Refactoring:

be.fedict.applet.service.JSON/Kml/PDF/VcardServlet -> 
be.fedict.applet.export...

be.fedict.applet.service.impl.JSON/Kml/PDF/VcardGenerator -> 
be.fedict.applet.export.impl...

be.fedict.applet.service.util -> be.fedict.applet.export.util

Original issue reported on code.google.com by bart.han...@fedict.be on 24 Feb 2010 at 10:07

@GoogleCodeExporter
Copy link
Author

Further thoughts:

- split JSONServlet into JSONServlet and JSONGenerator (like PDF/KML/...)

- probably the JSON/PDF/...Servlet can be replaced with a generic Servlet 
calling 
generator

- new Generator interface/superclass, methods byte[] generate(EidData data); 
and 
String getMIMEType();

- instead of 1 export-package combining all export formats, create a package 
be.fedict.applet.export.pdf..., a be.fedict.applet.export.vcard...  


Benefits: applet package is cleaner, would allow for selective adding/removing 
export 
formats

Original comment by bart.han...@fedict.be on 25 Feb 2010 at 12:51

@GoogleCodeExporter
Copy link
Author

I cannot do this for 1.0.1.GA since I need to keep binary compatibility at all 
time
for 1.0.x.GA releases.

Original comment by frank.co...@gmail.com on 25 Feb 2010 at 7:53

@GoogleCodeExporter
Copy link
Author

Scheduled this for 2.0.

Original comment by frank.co...@gmail.com on 14 Aug 2010 at 6:28

  • Changed state: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant