Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations | Config Table Names - Incomplete Implementation #4

Closed
bayareawebpro opened this issue May 29, 2020 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@bayareawebpro
Copy link

bayareawebpro commented May 29, 2020

Looks like you forgot to update the dropTable names to use the config:

https://github.com/assada/laravel-achievements/blob/master/src/Migrations/0000_00_00_000000_create_achievements_tables.php#L67

Schema::dropIfExists($this->achievement_progress);
Schema::dropIfExists($this->achievement_details);

Also Here:

https://github.com/assada/laravel-achievements/blob/master/src/Migrations/0000_00_00_000000_create_achievements_tables.php#L55

$table->foreign('achievement_id')->references('id')->on($this->achievement_details);
@bayareawebpro bayareawebpro changed the title Reverse Migration Migrations | Config Table Names - Incomplete Implementation May 29, 2020
@assada
Copy link
Owner

assada commented Jul 21, 2020

Thnx! Fixed 6c0d841

@assada assada closed this as completed Jul 21, 2020
@assada assada added the bug Something isn't working label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants