Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo list Structure #1

Merged
merged 13 commits into from Jun 6, 2022
Merged

Todo list Structure #1

merged 13 commits into from Jun 6, 2022

Conversation

assadounto
Copy link
Owner

In this project milestone

  • I created todo structure
  • Added hardcode object array for tasks
  • added function to iterate over the tasks array and populate an HTML list item element for each task.
  • generated docs/dis folder using webpack

@github-pages github-pages bot temporarily deployed to github-pages June 2, 2022 15:09 Inactive
@github-pages github-pages bot temporarily deployed to github-pages June 2, 2022 15:13 Inactive
@github-pages github-pages bot temporarily deployed to github-pages June 2, 2022 15:19 Inactive
Copy link

@Deepakdanger Deepakdanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @assadounto,

Good job so far! 👏
There are some issues that you still need to work on to go to the next project but you are almost there!

To Highlight 💯

  • No linter error ✔️
  • Website looks professional 👍

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

src/index.js Outdated
@@ -1,2 +1,43 @@
/* eslint-disable linebreak-style */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly remove it & resolve it manually rather than disable it. You can refer to here.

@github-pages github-pages bot temporarily deployed to github-pages June 2, 2022 16:00 Inactive
@github-pages github-pages bot temporarily deployed to github-pages June 2, 2022 16:19 Inactive
@github-pages github-pages bot temporarily deployed to github-pages June 2, 2022 16:33 Inactive
Copy link

@Lameck1 Lameck1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @assadounto,

You've done well addressing concerns from the previous review 👏🏼.
Tasks for this project are now successfully implemented 💯.

Highlights

  • Professional README ✔️
  • Clean code ✔️
  • Good commit messages ✔️

All the best with the next project.

You are free to merge this branch :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@assadounto assadounto merged commit 27fbd76 into main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants