Zombie.JS doesn't support javascript loaded via document.write #250

ThePixelDeveloper · 2012-01-04T11:15:01Z

Hi,

I've been having trouble with zombie.js testing when using the Google Maps API. I originally thought the problem was with the resources using query parameters in the URL. This appeared to be incorrect, here's my test for that:

css = new Browser();
css.visit('http://other.localhost/bugs/zombiejs/gmaps/css.html', function() {
    console.log();
    console.log('Calling css.html (CSS loaded with query string ...');
    console.log('Title : ' + css.text('title'));
});

Where css.html was

<!doctype html>
<html>
    <head>
        <title>Google Maps ZombieJS Bug</title>
        <link href="reset.css?time=1325674256" rel="stylesheet" type="text/css"></link>
    </head>
    <body>
        <p id="hello">Hello World</p>
    </body>
</html>

Here's my test case for zombie for testing to see if the bug is indeed a problem with document.write loaded scripts.

test case

write = new Browser();
write.visit('http://other.localhost/bugs/zombiejs/gmaps/write.html', function() {
    console.log();
    console.log('Calling write.html (Javascript loaded via document.write...');
    console.log('Title : ' + write.text('title'));
});

write.html

<!doctype html>
<html>
    <head>
        <title>Google Maps ZombieJS Bug</title>
        <script src="write.js" type="text/javascript"></script>
    </head>
    <body>
        <p id="hello">Hello World</p>
    </body>
</html>

write.js

var src = 'head.js';

document.write('<' + 'script src="' + src + '"' +
                   ' type="text/javascript"><' + '/script>');

head.js

alert('Bye World');

output

Calling write.html (Javascript loaded via document.write...
Title : <!doctype html>
<html>
    <head>
        <title>Google Maps ZombieJS Bug</title>
        <script src="write.js" type="text/javascript"></script>
    </head>
    <body>
        <p id="hello">Hello World</p>
    </body>
</html>

Using zombie@0.12.10

The text was updated successfully, but these errors were encountered:

assaf · 2012-01-04T19:23:14Z

No it doesn't. The default HTML parser doesn't support document.write.

I highly recommend not using document.write because it blocks the rendering loop, whereas adding script element allows JavaScript evaluating in parallel with page rendering for faster page speed.

ThePixelDeveloper · 2012-01-04T19:42:08Z

The problem was encountered when loading the Google Maps API, something I (and probably Google too) can't change too easily. I found a workout to my specific problem which was to add a callback argument to the URL which forces the method you described.

In the case of that not being possible I'd still ask you to support it. You even say you support it in your PDF under Readiness.

assaf · 2012-01-04T19:49:52Z

We're using the Google Maps with Zombie with no issues. Probably different part of it.

I removed the reference to document.write when we switched HTML parsers, sorry that it somehow snuck back in there.

ThePixelDeveloper · 2012-01-04T19:54:04Z

Since I worked around this issue and we agree it's not a bug, I'm closing this issue. Thanks assaf.

ThePixelDeveloper closed this as completed Jan 4, 2012

matt-glich mentioned this issue Jun 30, 2023

[Snyk] Fix for 1 vulnerabilities matt-glich/zombie#35

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zombie.JS doesn't support javascript loaded via document.write #250

Zombie.JS doesn't support javascript loaded via document.write #250

ThePixelDeveloper commented Jan 4, 2012

assaf commented Jan 4, 2012

ThePixelDeveloper commented Jan 4, 2012

assaf commented Jan 4, 2012

ThePixelDeveloper commented Jan 4, 2012

Zombie.JS doesn't support javascript loaded via document.write #250

Zombie.JS doesn't support javascript loaded via document.write #250

Comments

ThePixelDeveloper commented Jan 4, 2012

assaf commented Jan 4, 2012

ThePixelDeveloper commented Jan 4, 2012

assaf commented Jan 4, 2012

ThePixelDeveloper commented Jan 4, 2012