-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: rename plugins to "assemble-middleware-*"? #504
Comments
I think that it would make it clearer. The grunt-contrib- isn't very confusing because they are all plugins, but assemble doesn't have that. |
very good points! thanks! |
I think these should be |
Can you explain this 'rebuil with verbs'? |
Perhaps the strategy for changing the plugins should be more explicit. For instance, all plugins in their instance should branch out the code to a branch called v4.x or something. |
@doowb I like that, though will there be both be middleware and plugins? Because if so, the difference should be clarified somewhere. |
@LaurentGoderre I updated the description above.
That's the plan! here are three related issues:
I'll be updating these with more info, over the next day or so. the goal is to have a complete strategy for updating plugins, helper and documentation in general |
@Melindrea: I was just talking to @jonschlinkert and we're planning on middleware and plugins, but we'll probably push that off to the next version. I think we need to come up with a better definition between the differences and where they should be used. @LaurentGoderre when I'm updating a plugin/helper of v0.5, I usually create a new branch named by the next minor version since this will be a breaking change. handlebars-helper-rel is a good example (even though it's a helper and not a plugin). This way, it can be tested by pointing directly to the repo without pushing it up to npm. @jonschlinkert responded while I was typing... so his stuff too 😉 |
so in a nutshell, no. we'll just do one. middleware seems correct to me as well. |
👍 I like the term middleware. |
@doowb I feel that the opposite should be true. While master point to the latest, there should be a branch poiting to the "old" version. |
@LaurentGoderre not while the master is still the current version. there shouldn't be a branch for any version but the "next" one. tags serve that purpose. perhaps we should continue this on another issue though? |
Sorry about that....I thought that npm handle deprecation through the package.json since it doesn`t there probably is not need forr the backwards branch |
no prob @LaurentGoderre! I appreciate the precaution! |
is it going to be |
👍 |
Btw, as we rename, do you deprecate the previous module on npm? |
no but it's not a bad idea. |
What is cool is that you can customize the message telling the users what the new package name is. |
BTW, I can't rename the repo itself because I have push rights only but I can start the work if you rename it. |
Actually, I was deprecating the old modules when I renamed them. I put a message saying that it was renamed to |
Yeah that's perfect! |
👍 |
closing based on age and since we've made a lot of changes since this was created |
I propose that we rename all of the plugins to
assemble-middleware-foo
instead ofcontrib
.IMO, since v0.5.0 plugins aren't backwards compatible anyway, this shouldn't be an issue. npm will still have the contrib plugins for anyone who needs them. Also, GitHub automatically sets up redirects when repos are renamed (all URLs, including git endpoints).
Any thoughts? Am I missing something?
middleware that need to be renamed:
For each, we'll need to:
Missing anything?
The text was updated successfully, but these errors were encountered: