Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CommandCargoExt to pass build arguments #34

Closed
quininer opened this issue Jul 28, 2018 · 3 comments
Closed

Allow CommandCargoExt to pass build arguments #34

quininer opened this issue Jul 28, 2018 · 3 comments
Labels
breaking-change enhancement Improve the expected question Uncertainty is involved

Comments

@quininer
Copy link

Sometimes we want to provide testing for different features bin.

@epage
Copy link
Contributor

epage commented Aug 1, 2018

Sorry I haven't responded earlier.

Is the primary concern features?

Some of the challenges

  • Right now, we directly return a Command. Adding more to this API makes it so we can't. How should we bridge that gap?
  • What is in scope and what isn't?
  • The API for the main_binary_paths

@epage
Copy link
Contributor

epage commented Aug 3, 2018

I've started mapping out what we might due to the API to help

Please check out #44 and provide feedback

@epage
Copy link
Contributor

epage commented Sep 4, 2018

The recommendation is to call into escargot directly. You can find an example within assert_cmd: https://github.com/assert-rs/assert_cmd/blob/master/src/cargo.rs#L137

@epage epage closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement Improve the expected question Uncertainty is involved
Projects
None yet
Development

No branches or pull requests

2 participants