Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overloaded method contains of AbstractByteArrayAssert and AbstractShortArrayAssert #2077

Closed
wants to merge 6 commits into from
Closed

Add overloaded method contains of AbstractByteArrayAssert and AbstractShortArrayAssert #2077

wants to merge 6 commits into from

Conversation

mayralgr
Copy link
Contributor

@mayralgr mayralgr commented Dec 16, 2020 •
edited by scordio

Check List:

@mayralgr mayralgr mentioned this pull request Dec 16, 2020
Closed
8 tasks
@mayralgr mayralgr marked this pull request as ready for review December 16, 2020 21:55
scordio
scordio requested changes Dec 25, 2020
View reviewed changes
Copy link
Member

@scordio scordio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mayralgr, just general javadoc and code formatting to be adjusted. Would you mind taking care of it? Or I can take it over.

src/main/java/org/assertj/core/api/AbstractByteArrayAssert.java Outdated Show resolved Hide resolved
src/main/java/org/assertj/core/api/AbstractByteArrayAssert.java Show resolved Hide resolved
src/main/java/org/assertj/core/api/AbstractByteArrayAssert.java Outdated Show resolved Hide resolved
src/main/java/org/assertj/core/api/AbstractByteArrayAssert.java Outdated Show resolved Hide resolved
...sertj/core/api/bytearray/ByteArrayAssert_containsExactlyInAnyOrder_with_Byte_array_Test.java Outdated Show resolved Hide resolved
@scordio scordio self-assigned this Dec 25, 2020
@mayralgr
Copy link
Contributor Author

@scordio all checks passed and requested changes were made. Let me know if anything else is missing 😁
Thank you!

Happy holidays!

@scordio scordio closed this in 6936b61 Dec 30, 2020
@scordio
Copy link
Member

scordio commented Dec 30, 2020

Integrated, thanks @mayralgr and happy holidays to you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scordio scordio Awaiting requested review from scordio

Assignees

@scordio scordio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayralgr @scordio