New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2530: Add spotless check for formatting preferences #2533
Conversation
I will rebase this PR and mark it as ready once #2534 is merged :) |
6d7fe92
to
bccba84
Compare
There is nothing wrong with your changes, it's rather a general problem we have with pitest. Feel free to ignore that failure. |
alright, thanks! in that case this PR is ready for review :) |
I'm not opposed to applying spotless but I think we need to make the spotless config as close as possible to our existing formatting preferences, there are too many changes in this PR. |
Superseded by #3115. |
Check List:
All the changes relevant to adding the spotless dependency are in the first commit (48a9b14) - I suggest looking at that instead of all the changes that resulted from applying spotless. Apart from adding the spotless dependency and a github workflow, I also added information about spotless to the contributing guidelines.