Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2530: Add spotless check for formatting preferences #2533

Closed
wants to merge 2 commits into from

Conversation

hjir
Copy link
Contributor

@hjir hjir commented Mar 21, 2022

Check List:

All the changes relevant to adding the spotless dependency are in the first commit (48a9b14) - I suggest looking at that instead of all the changes that resulted from applying spotless. Apart from adding the spotless dependency and a github workflow, I also added information about spotless to the contributing guidelines.

@hjir hjir changed the title #2530: Add spotless check for formatting preferences Draft: #2530: Add spotless check for formatting preferences Mar 21, 2022
@hjir hjir marked this pull request as draft March 21, 2022 12:54
@hjir hjir changed the title Draft: #2530: Add spotless check for formatting preferences #2530: Add spotless check for formatting preferences Mar 21, 2022
@hjir
Copy link
Contributor Author

hjir commented Mar 21, 2022

I will rebase this PR and mark it as ready once #2534 is merged :)

@hjir hjir marked this pull request as ready for review March 21, 2022 13:39
@hjir
Copy link
Contributor Author

hjir commented Mar 26, 2022

@scordio I picked this up from #2530 but now the pitest pipeline is failing (from what I saw in the logging, there seems to be an OutOfMemoryError). do you have any pointers on what I can do about this?

@scordio
Copy link
Member

scordio commented Mar 26, 2022

There is nothing wrong with your changes, it's rather a general problem we have with pitest. Feel free to ignore that failure.

@hjir
Copy link
Contributor Author

hjir commented Mar 27, 2022

There is nothing wrong with your changes, it's rather a general problem we have with pitest. Feel free to ignore that failure.

alright, thanks! in that case this PR is ready for review :)

@joel-costigliola
Copy link
Member

I'm not opposed to applying spotless but I think we need to make the spotless config as close as possible to our existing formatting preferences, there are too many changes in this PR.

@scordio scordio added this to the 3.25.0 milestone Jul 4, 2023
scordio added a commit that referenced this pull request Jul 20, 2023
This is a preliminary step before the introduction of Spotless.
Relates to #2530 and #2533.
scordio added a commit that referenced this pull request Jul 20, 2023
This is a preliminary step before the introduction of Spotless.
Relates to #2530 and #2533.
scordio added a commit that referenced this pull request Jul 20, 2023
This is a preliminary step before the introduction of Spotless.
Relates to #2530 and #2533.
@scordio scordio added the status: superseded An issue that has been superseded by another label Jul 20, 2023
@scordio
Copy link
Member

scordio commented Jul 20, 2023

Superseded by #3115.

@scordio scordio closed this Jul 20, 2023
@scordio scordio removed this from the 3.25.0 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotless check for formatting preferences
3 participants