Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRRXML is now always built as a dynamic lib on all platforms, and not deployed on Windows #2411

Closed
RichardTea opened this issue Apr 8, 2019 · 1 comment
Closed

IRRXML is now always built as a dynamic lib on all platforms, and not deployed on Windows #2411

RichardTea opened this issue Apr 8, 2019 · 1 comment

Comments

@RichardTea
Copy link
Contributor

RichardTea commented Apr 8, 2019 •
edited
Loading

Commit ba6a738 to fix #1650 has changed all platforms, not just BSD.

This has now broken the Windows build, and possibly others, as the knock-on changes were not applied.

Please revert these commits to IRRXML, or alternatively make building IRRXML as a dynamic library optional.
Adding additional DLLs without explictly calling them out as new dependencies is extremely bad form.
@RichardTea RichardTea changed the title IRRXML is now always build dynamic lib on all platforms IRRXML is now always built as a dynamic lib on all platforms, and not deployed on Windows Apr 8, 2019
@kimkulling
Copy link
Member

Good point, please check #2414

@JekaS178RUS JekaS178RUS mentioned this issue May 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimkulling @RichardTea