Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of PyAssimp on PyPI #3072

Open
JerzySpendel opened this issue Mar 18, 2020 · 4 comments
Open

Update the version of PyAssimp on PyPI #3072

JerzySpendel opened this issue Mar 18, 2020 · 4 comments
Labels
Bug Global flag to mark a deviation from expected behaviour pyassimp The Python Assimp port

Comments

@JerzySpendel
Copy link

Current version of PyAssimp on the PyPI doesn't work. It throws errors, because looks like at some point you try to access aketrans attribute of bytes (I guess typo from maketrans method of bytes class) object which is no longer an issue if I install package from setup.py.

So simply realeasing new version should fix this.

@umlaeute
Copy link
Contributor

i think this requires attention.
there have been a couple of bug-reports that i think all boil down to people installing an outdated and broken version of pyassimp from pypi:

(some of these bugs are open, but i have the gut feeling, that they are actually fixed with current versions of assimp/pyassimp).

i think the native pypi home for the pyassimp package is https://pypi.org/project/pyassimp/ owned by @severin-lemaignan and @rspencer01 (it's the only one of the various assimp bindings you find on pypi, that is directly built from the bindings found in this repository)

i propose to reactive this pypi package (possibly adding the assimp maintainers (@kimkulling , ...) to the pypi team), and using some github action to automatically upload new packages to pypi whenever there's a new assimp release.

see https://github.com/marketplace/actions/pypi-publish

@severin-lemaignan
Copy link
Contributor

hi! I've just re-uploaded pyassimp to pypi: https://pypi.org/project/pyassimp/5.2.5/

Very happy to hand-over the maintenance of the pypi project to someone more active in the project, though!

@severin-lemaignan
Copy link
Contributor

FYI, #5151

@umlaeute
Copy link
Contributor

thanks for anybody involved.

now comes the time to reveal that i am just bigmouthing, and don't have any actual powers to proceed.

afaict, we have two offers to use an existing PyPi project to directly push the pyassimp package on release.
in general i would very much welcome it, if some members of the Assimp team had write access to the "canonical" PyPi project (bus factor, and things)

should we take this opportunity? how does automatic pushing to pypi (via a github action) sound? (i don't have any practical experience with pushing to pypi (neither manually nor via gh-actions) but I assume it is straight-forward)

is this of interest to the assimp team? (ping @dnadlinger , @turol , @acgessler , @kimkulling , @Schrompf )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Global flag to mark a deviation from expected behaviour pyassimp The Python Assimp port
Projects
Status: No status
Development

No branches or pull requests

4 participants