Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested animation name being lost in Collada #4597

Merged

Conversation

luca-della-vedova
Copy link
Contributor

Hi!

This PR fixes an issue with the name of the animation being empty when parsing nested collada animations. I also added a unit test that fails without the change and succeeds with.
Specifically, the tested collada file has the following animation library:

   <library_animations>
    <animation id="action_container-Armature" name="Armature">
      <animation id="Armature_ArmatureAction_transform" name="Armature">
[...]

Without the change, the animation name is empty, with the change it it set to Armature.

@kimkulling kimkulling merged commit f4c8b55 into assimp:master Jul 5, 2022
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants