Bug: FTBFS with g++-13

[umlaeute]

$  g++ --version
g++ (Debian 13.2.0-6) 13.2.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ make VERBOSE=1 -k
/usr/bin/cmake -S.../assimp -B.../assimp/build-make --check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start .../assimp/build-make/CMakeFiles .../assimp/build-make//CMakeFiles/progress.marks
make  -f CMakeFiles/Makefile2 all
make[1]: Entering directory '.../assimp/build-make'
make  -f contrib/zlib/CMakeFiles/zlibstatic.dir/build.make contrib/zlib/CMakeFiles/zlibstatic.dir/depend
make[2]: Entering directory '.../assimp/build-make'
cd .../assimp/build-make && /usr/bin/cmake -E cmake_depends "Unix Makefiles" .../assimp .../assimp/contrib/zlib .../assimp/build-make .../assimp/build-make/contrib/zlib .../assimp/build-make/contrib/zlib/CMakeFiles/zlibstatic.dir/DependInfo.cmake "--color="
make[2]: Leaving directory '.../assimp/build-make'
make  -f contrib/zlib/CMakeFiles/zlibstatic.dir/build.make contrib/zlib/CMakeFiles/zlibstatic.dir/build
make[2]: Entering directory '.../assimp/build-make'
make[2]: Nothing to be done for 'contrib/zlib/CMakeFiles/zlibstatic.dir/build'.
make[2]: Leaving directory '.../assimp/build-make'
[  5%] Built target zlibstatic
make  -f code/CMakeFiles/assimp.dir/build.make code/CMakeFiles/assimp.dir/depend
make[2]: Entering directory '.../assimp/build-make'
cd .../assimp/build-make && /usr/bin/cmake -E cmake_depends "Unix Makefiles" .../assimp .../assimp/code .../assimp/build-make .../assimp/build-make/code .../assimp/build-make/code/CMakeFiles/assimp.dir/DependInfo.cmake "--color="
Dependencies file "code/CMakeFiles/assimp.dir/AssetLib/MDL/MDLLoader.cpp.o.d" is newer than depends file ".../assimp/build-make/code/CMakeFiles/assimp.dir/compiler_depend.internal".
Consolidate compiler generated dependencies of target assimp
make[2]: Leaving directory '.../assimp/build-make'
make  -f code/CMakeFiles/assimp.dir/build.make code/CMakeFiles/assimp.dir/build
make[2]: Entering directory '.../assimp/build-make'
[  5%] Building CXX object code/CMakeFiles/assimp.dir/AssetLib/MDL/MDLLoader.cpp.o
cd .../assimp/build-make/code && /usr/bin/c++ -DASSIMP_BUILD_DLL_EXPORT -DASSIMP_BUILD_NO_C4D_IMPORTER -DASSIMP_BUILD_NO_M3D_EXPORTER -DASSIMP_BUILD_NO_M3D_IMPORTER -DASSIMP_IMPORTER_GLTF_USE_OPEN3DGC=1 -DMINIZ_USE_UNALIGNED_LOADS_AND_STORES=0 -DOPENDDLPARSER_BUILD -DRAPIDJSON_HAS_STDSTRING=1 -DRAPIDJSON_NOMEMBERITERATORCLASS -Dassimp_EXPORTS -I.../assimp/build-make/include -I.../assimp/build-make -I.../assimp/include -I.../assimp/code -I.../assimp/. -I.../assimp/contrib/zlib -I.../assimp/build-make/contrib/zlib -I.../assimp/code/../contrib/pugixml/src -I.../assimp/code/../contrib/rapidjson/include -I.../assimp/code/../contrib -I.../assimp/code/../contrib/unzip -I.../assimp/code/../contrib/openddlparser/include -I.../assimp/code/../include -I.../assimp/build-make/code/../include -I.../assimp/code/.. -fvisibility=hidden -fno-strict-aliasing -Wall  -O3 -DNDEBUG -std=gnu++17 -fPIC -Wno-dangling-reference -Wall -Werror -MD -MT code/CMakeFiles/assimp.dir/AssetLib/MDL/MDLLoader.cpp.o -MF CMakeFiles/assimp.dir/AssetLib/MDL/MDLLoader.cpp.o.d -o CMakeFiles/assimp.dir/AssetLib/MDL/MDLLoader.cpp.o -c .../assimp/code/AssetLib/MDL/MDLLoader.cpp
In file included from /usr/include/c++/13/bits/specfun.h:43,
                 from /usr/include/c++/13/cmath:3699,
                 from .../assimp/include/assimp/vector2.h:53,
                 from .../assimp/include/assimp/types.h:64,
                 from .../assimp/include/assimp/IOStream.hpp:53,
                 from .../assimp/include/assimp/DefaultIOStream.h:55,
                 from .../assimp/include/assimp/Exceptional.h:49,
                 from .../assimp/include/assimp/BaseImporter.h:52,
                 from .../assimp/code/AssetLib/MDL/MDLLoader.h:50,
                 from .../assimp/code/AssetLib/MDL/MDLLoader.cpp:51:
In static member function ‘static _Up* std::__copy_move<_IsMove, true, std::random_access_iterator_tag>::__copy_m(_Tp*, _Tp*, _Up*) [with _Tp = long unsigned int; _Up = long unsigned int; bool _IsMove = false]’,
    inlined from ‘_OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at /usr/include/c++/13/bits/stl_algobase.h:506:30,
    inlined from ‘_OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at /usr/include/c++/13/bits/stl_algobase.h:533:42,
    inlined from ‘_OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at /usr/include/c++/13/bits/stl_algobase.h:540:31,
    inlined from ‘_OI std::copy(_II, _II, _OI) [with _II = long unsigned int*; _OI = long unsigned int*]’ at /usr/include/c++/13/bits/stl_algobase.h:633:7,
    inlined from ‘std::vector<bool, _Alloc>::iterator std::vector<bool, _Alloc>::_M_copy_aligned(const_iterator, const_iterator, iterator) [with _Alloc = std::allocator<bool>]’ at /usr/include/c++/13/bits/stl_bvector.h:1306:28,
    inlined from ‘void std::vector<bool, _Alloc>::_M_reallocate(size_type) [with _Alloc = std::allocator<bool>]’ at /usr/include/c++/13/bits/vector.tcc:851:40,
    inlined from ‘void std::vector<bool, _Alloc>::reserve(size_type) [with _Alloc = std::allocator<bool>]’ at /usr/include/c++/13/bits/stl_bvector.h:1094:17,
    inlined from ‘Assimp::MDL::IntSharedData_MDL7::IntSharedData_MDL7()’ at .../assimp/code/AssetLib/MDL/MDLFileData.h:879:32,
    inlined from ‘void Assimp::MDLImporter::InternReadFile_3DGS_MDL7()’ at .../assimp/code/AssetLib/MDL/MDLLoader.cpp:1364:29:
/usr/include/c++/13/bits/stl_algobase.h:437:30: error: ‘void* __builtin_memmove(void*, const void*, long unsigned int)’ forming offset 8 is out of the bounds [0, 8] [-Werror=array-bounds=]
  437 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
      |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [code/CMakeFiles/assimp.dir/build.make:1518: code/CMakeFiles/assimp.dir/AssetLib/MDL/MDLLoader.cpp.o] Error 1
make[2]: Target 'code/CMakeFiles/assimp.dir/build' not remade because of errors.
make[2]: Leaving directory '.../assimp/build-make'
make[1]: *** [CMakeFiles/Makefile2:204: code/CMakeFiles/assimp.dir/all] Error 2
make[1]: Target 'all' not remade because of errors.
make[1]: Leaving directory '.../assimp/build-make'
make: *** [Makefile:136: all] Error 2
make: Target 'default_target' not remade because of errors.

$

gcc-13 is the default compiler on Debian/trixie (currently Debian/testing) and Ubuntu/mantic

right now, i don't really have time to dig further into this...

[turol]

Looks like it's inside the stdlib from a reserve call. I'm calling compiler bug. Just disable warnings as errors.

[umlaeute]

ah, i missed the all warnings being treated as errors line (although i'm using -DASSIMP_WARNINGS_AS_ERRORS=OFF in my Debian builds anyhow, as of https://bugs.debian.org/1012898).

i'd be weary to call this a compiler bug (but then: i don't know much about these things).
if you are sure about it, feel free to close this issue.

[kimkulling]

I will!