Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent compilers are warning about pessimizations #3

Open
gotnone opened this issue Feb 12, 2021 · 1 comment
Open

Recent compilers are warning about pessimizations #3

gotnone opened this issue Feb 12, 2021 · 1 comment

Comments

@gotnone
Copy link

gotnone commented Feb 12, 2021

I have been playing around with rangeless as a faster compiling alternative to std::ranges and ranges-v3. I have been getting some compiler warnings that there are redundant or pessimizing moves in fn::transform and in fn::take_while. Would you consider removing the unnecessary std::move wrappers on lines 1592 and 1846? See this example. Thanks.

@ast-al
Copy link
Owner

ast-al commented Feb 14, 2021

Thanks for the suggestion! I'll have a look at it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants