Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for C++? #417

Closed
torshepherd opened this issue May 26, 2023 · 1 comment · Fixed by #459
Closed

Support for C++? #417

torshepherd opened this issue May 26, 2023 · 1 comment · Fixed by #459
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@torshepherd
Copy link

What would it take to add support for C++? Seems like there is a tree-sitter grammar for it: https://github.com/tree-sitter/tree-sitter-cpp

If it's not too much work I could make a PR for it
@HerringtonDarkholme HerringtonDarkholme added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 26, 2023
@HerringtonDarkholme
Copy link
Member

I believe I have tried that before. But tree-sitter-cpp's rust binding is still in 0.19 version. It is not updated to the latest v0.20.

https://github.com/tree-sitter/tree-sitter-cpp/tree/master/bindings/rust

So it probably will not work if we just add tree-sitter-cpp as a dependency. Sadly. We need to first bump the version and release it in crates.io.

@liushuyu liushuyu mentioned this issue Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(language): add initial support for C++ liushuyu/ast-grep
2 participants
@HerringtonDarkholme @torshepherd