Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Chromium in the default Unix binaries #10

Closed
offray opened this issue Jan 10, 2023 · 4 comments
Closed

Adding support for Chromium in the default Unix binaries #10

offray opened this issue Jan 10, 2023 · 4 comments

Comments

@offray
Copy link

offray commented Jan 10, 2023

Hi and thanks for this project. I have been using it for the MiniDocs package, which extends documentation capabilities of Lepiter with light formats, including Mardeep preview and exportation.

A single line could be added to UnixChromePlatform class >>defaultExecutableLocations, so Pharo-Chrome would detect installations of Chromium in Unix, for those of us that prefer it over Chrome.

Thanks.

@astares
Copy link
Owner

astares commented Jan 10, 2023

@offray Sure - if you need it quick just send a PR

@offray
Copy link
Author

offray commented Jan 11, 2023

@astares I'm not in any particular rush, so I will wait. Thought I will be happy of learning about Git based workflows, particularly on Pharo/GToolkit.

@astares
Copy link
Owner

astares commented Jan 11, 2023

On my system I used snap now to install. So we have to additionally add " '/snap/bin/chromium'" as a possible path

@astares
Copy link
Owner

astares commented Jan 11, 2023

@offray Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants