Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all errors returned by the Realm Management backend instead of returning 500 #683

Closed
rbino opened this issue Apr 1, 2022 · 1 comment
Closed

Handle all errors returned by the Realm Management backend instead of returning 500 #683

rbino opened this issue Apr 1, 2022 · 1 comment
Labels
app:realm_management_api This issue or pull request is about astarte_realm_management_api application

Comments

@rbino
Copy link
Collaborator

rbino commented Apr 1, 2022

Currently Realm Management API does not handle many errors that can be returned, see e.g. this, this, or this, failing instead with "500 Internal Server Error", which does not help the user much.

The way to handle those is adding a clause to the relevant controller (e.g. TriggerController for the ones linked above) and a render function in the relative View.

Once the clause is added, this call actually succeeds (since the error atom is now existing in the application) and the error is correctly rendered.
@rbino rbino added the app:realm_management_api This issue or pull request is about astarte_realm_management_api application label Apr 1, 2022
@Annopaolo Annopaolo mentioned this issue Apr 8, 2022
Merged
@Annopaolo
Copy link
Collaborator

Closed by #686.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:realm_management_api This issue or pull request is about astarte_realm_management_api application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbino @Annopaolo