Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not shown in PDF output (but are correct in PNG and browser) #297

Closed
krisvanrens opened this issue Sep 29, 2023 · 1 comment · Fixed by #315
Closed

Images not shown in PDF output (but are correct in PNG and browser) #297

krisvanrens opened this issue Sep 29, 2023 · 1 comment · Fixed by #315
Labels

Comments

@krisvanrens
Copy link

krisvanrens commented Sep 29, 2023

Hi!

I'm using your great tool Decktape to export reveal.js-based presentations on programming.

To support slides with multiple programming languages on a single slide, I added language logo annotations in CSS (using ::before and ::after selectors). The result looks like this:

However, when using the multiple code blocks with the same language, the images are not showing up in the PDF anymore. They are correctly displayed in the browser and when using the --screenshot option to create images though. Here's what I mean:

It does actually work correctly when only using a just a single code block for each language. My feeling is that the CSS is of some influence here...but that doesn't explain why it just works in all browsers I've tested (or in the screenshot mode). Also, when using a single language only once, and another one twice, the logo for the single language is only shown.

Thanks in advance for looking at this! 😃

Please find the links to input HTML file, and the output PDF attached below. If you need any more information, let me know!

@krisvanrens
Copy link
Author

@astefanutti Thanks so much for looking into this. You do awesome work with decktape 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants